For linux msm/ramdump subcmd#183
Merged
andersson merged 3 commits intolinux-msm:masterfrom Feb 2, 2026
Merged
Conversation
Providing qdl-ramdump as a separate executable has resulted in it not being part of several of the distributions that include qdl. Also, users that knows that qdl supports ramdumps are looking for it "in" qdl, not a related tool. Make "ramdump" a subcommand, just like "qdl list", to improve the ergonomics of the tool. The implementation is a (almost) verbatim copy of ramdump.c. The existing executable is kept in order to not break those distributions that explicitly do package said executable. At some point we should figure out how to drop this. Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
Dumping all the DDR takes significant time and there's currently no user-visible feedback provided to indicate that even the process has started. Solve this by wiring up the ux module and provide a progress bar while dumping segments, as well as information as the segments are skipped or dumped. Add missing ux_init() to the ramdump setup, and make sure to clamp value to max in the progress calculation, to avoid funky issues when progress is made beyond the size of the chunk. Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
Rather than mixing subcommands and the default "flash" operation, split the flashing mechanism out into its own subcommand function to clean up the main function. Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ramdump more user friendly.